Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV of utility crates to 1.56 #2733

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Bump MSRV of utility crates to 1.56 #2733

merged 1 commit into from
Mar 30, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Mar 30, 2023

This bumps MSRV of utility crates (futures, futures-util, futures-task, futures-macro, futures-executor, futures-channel, futures-test) to 1.56.

syn 2.0 requires 1.56.
Unblock #2730

syn 2.0 requires 1.56.
@taiki-e taiki-e added the 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. label Mar 30, 2023
@taiki-e taiki-e merged commit 3fc74df into master Mar 30, 2023
@taiki-e taiki-e deleted the msrv branch March 30, 2023 16:42
taiki-e added a commit that referenced this pull request Mar 30, 2023
@taiki-e taiki-e mentioned this pull request Mar 30, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Mar 30, 2023
taiki-e added a commit that referenced this pull request Mar 30, 2023
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Mar 30, 2023
Some how I'd understood that `futures` had reasonable MSRV
guarantees (e.g. at least Debian stable), but apparently that isn't
actually the case, as they bumped it to upgrade to syn (with
apparently no actual features or bugfixes added as a result?) with
no minor version bump or any available alternative (unlike Tokio,
which does LTS releases).

Luckily its relatively easy to just drop the `futures` dependency -
it means a new connection for each request, which is annoying, but
certainly not the end of the world, and its easier than trying to
deal with pinning `futures`.

See rust-lang/futures-rs#2733
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this pull request Mar 30, 2023
Some how I'd understood that `futures` had reasonable MSRV
guarantees (e.g. at least Debian stable), but apparently that isn't
actually the case, as they bumped it to upgrade to syn (with
apparently no actual features or bugfixes added as a result?) with
no minor version bump or any available alternative (unlike Tokio,
which does LTS releases).

Luckily its relatively easy to just drop the `futures` dependency -
it means a new connection for each request, which is annoying, but
certainly not the end of the world, and its easier than trying to
deal with pinning `futures`.

See rust-lang/futures-rs#2733
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 30, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [futures](https://rust-lang.github.io/futures-rs) ([source](https://github.com/rust-lang/futures-rs)) | dependencies | patch | `0.3.27` -> `0.3.28` |

---

### Release Notes

<details>
<summary>rust-lang/futures-rs</summary>

### [`v0.3.28`](https://github.com/rust-lang/futures-rs/blob/HEAD/CHANGELOG.md#&#8203;0328---2023-03-30)

[Compare Source](rust-lang/futures-rs@0.3.27...0.3.28)

-   Update to syn 2. This raises MSRV of utility crates to 1.56. ([#&#8203;2730](rust-lang/futures-rs#2730), [#&#8203;2733](rust-lang/futures-rs#2733))
-   Fix bug in `FlattenUnordered` ([#&#8203;2726](rust-lang/futures-rs#2726), [#&#8203;2728](rust-lang/futures-rs#2728))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4yNC42IiwidXBkYXRlZEluVmVyIjoiMzUuMjQuNiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1843
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
jbesraa pushed a commit to jbesraa/rust-lightning that referenced this pull request Apr 8, 2023
Some how I'd understood that `futures` had reasonable MSRV
guarantees (e.g. at least Debian stable), but apparently that isn't
actually the case, as they bumped it to upgrade to syn (with
apparently no actual features or bugfixes added as a result?) with
no minor version bump or any available alternative (unlike Tokio,
which does LTS releases).

Luckily its relatively easy to just drop the `futures` dependency -
it means a new connection for each request, which is annoying, but
certainly not the end of the world, and its easier than trying to
deal with pinning `futures`.

See rust-lang/futures-rs#2733
optout21 pushed a commit to optout21/rust-lightning that referenced this pull request Jul 24, 2023
Some how I'd understood that `futures` had reasonable MSRV
guarantees (e.g. at least Debian stable), but apparently that isn't
actually the case, as they bumped it to upgrade to syn (with
apparently no actual features or bugfixes added as a result?) with
no minor version bump or any available alternative (unlike Tokio,
which does LTS releases).

Luckily its relatively easy to just drop the `futures` dependency -
it means a new connection for each request, which is annoying, but
certainly not the end of the world, and its easier than trying to
deal with pinning `futures`.

See rust-lang/futures-rs#2733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant